[Bug: Minor] Broken RSVP emails

thatbloke

Junior Administrator
I got an email this morning in my hotmail from THN reminding me that I have RSVP's for an event tonight... But it has lots of Forum BBCode tags left in it which makes it pretty unreadable...

Here's what I got:

My Hotmail said:
[noparse]
Dear thatbloke,

This is a reminder that an event you RSVP'd for is scheduled to begin soon. If you are no longer able to attend, please update your RSVP status. Otherwise, we look forward to seeing you there!

Event: [2142] Match Vs =YL=
Scheduled Start Date: 21 Oct 07 (1 Day)
===========================================================
Event:
Belgrade16.jpg

Belgrade16

Tunis16.jpg

Tunis16

Fixture:
UK.gif
=YL= v [THN]
UK.gif
Date:
Sun 21st Oct 2007
Time:
20:00
Server:
85.236.101.19:16967
PsB Streaming:
light_w.gif
Last streamed on 15th October 2007 at 10:38am GMT
Password:
n/a
Rules: ED league rules
===========================================================

To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=293&day=2007-10-21

All the best,

TheHavenNet
[/noparse]

I think they need to be replaced with HTML...
 

Ronin Storm

Administrator
Staff member
Re: Broken RSVP emails

I'll take a look. It might be the overload of image et al in the body because I've had similar sorts of mails and I think they've been fine.

Please post if you get any more weird ones, though, as it'll help me with testing any fixes needed.
 

Traxata

Junior Administrator
Re: Broken RSVP emails

Ahhh, Nor have I.

Its all fine for me, even though Gmail just turns it into plain text


Hazaa :)


*Edit : Woops i told a little lie .... *
[noparse]Dear Traxata,

This is a reminder that an event you RSVP'd for is scheduled to begin soon. If you are no longer able to attend, please update your RSVP status. Otherwise, we look forward to seeing you there!

Event: [2142] Match Vs =YL=
Scheduled Start Date: 21 Oct 07 (1 Day)
===========================================================
Event:
Belgrade16.jpg

Belgrade16

Tunis16.jpg

Tunis16

Fixture:
UK.gif
=YL= v [THN]
UK.gif
Date:
Sun 21st Oct 2007
Time:
20:00
Server:
PsB Streaming:
light_w.gif
Last streamed on 15th October 2007 at 10:38am GMT
Password:
n/a
Rules: ED league rules
===========================================================

To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=293&day=2007-10-21

All the best,


TheHavenNet[/noparse]
 

Ronin Storm

Administrator
Staff member
Re: Broken RSVP emails

It partly seems to be because the bbCode isn't complete and so possibly doesn't parse fully. I've hit the "remove formatting" button on that event's details, which has knackered its readability a bit but hopefully will remove the issue. Could you let me know how that looks when you get the 24 hour reminder?
 

Traxata

Junior Administrator
Re: Broken RSVP emails

Will do,


The thing with the events is i just Copy & paste the Enemy Down info straight into it, save it. Edit it and fix the formatting so it appears :)


*edity goodness* TF2 Event has spammed me

[noparse]
Dear Traxata,

An event you were interested in at TheHavenNet is scheduled to begin soon. You previously RSVP'd "Maybe." If you will be able to attend, please take a moment to update your RSVP status. Attached below are the details of the event.

Event: Team Fortress 2 night
Scheduled Start Date: 23 Oct 07 (1 Day)
===========================================================
By this time everyone will hopefully have TF2 that will be getting it (I'm thinking of actually disc owners as well as steam downloaders) So i think we should have our first mass THNer matches on the server.

Start Time: 7pm
Date: Tuesday 23rd October

Mass fraggage is required. Plus if we all add ourselves to each others friend list we can get the 8 friend achievement hopefully.

SIGN UP YOU MAGGOTS!
===========================================================

To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=291&day=2007-10-23

All the best,


TheHavenNet[/noparse]
 

thatbloke

Junior Administrator
Re: Broken RSVP emails

Just got a 24 hour reminder for the 2142 match tomorrow night and I got the following:

[noparse]Dear thatbloke, This is a reminder that an event you RSVP'd for is scheduled to begin soon. If you are no longer able to attend, please update your RSVP status. Otherwise, we look forward to seeing you there! Event: [2142] ED Ladder match against =ProX= Scheduled Start Date: 31 Oct 07 (1 Day)===========================================================
Gibraltar16.jpg
Gibraltar16Fixture:
UK.gif
=ProX= v [THN]
UK.gif
Date: Wed 31st Oct 2007Time: 20:00Server: 193.93.46.49:16569PsB Streaming:
light_w.gif
Last streamed on 26th October 2007 at 9:44am GMT Password: proxmatchRules: Conquest,UK Time,6v6,2 x 20 mins,2ndmap = your choise (Cerbere) =========================================================== To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=305&day=2007-10-31 All the best, TheHavenNet[/noparse]

PS: ignore the lack of newlines, for some reason they didnt copy
 

thatbloke

Junior Administrator
got another screwed one today:

[noparse]
Dear thatbloke,

This is a reminder that an event you RSVP'd for is scheduled to begin soon. If you are no longer able to attend, please update your RSVP status. Otherwise, we look forward to seeing you there!

Event: [2142] Match Vs cC
Scheduled Start Date: 25 Nov 07 (1 Day)
===========================================================
Event:
Gibraltar16.jpg

Gibraltar16

Minsk16.jpg

Minsk16

Fixture:
UK.gif
cC v [THN]
UK.gif
Date:
Sun 25th Nov 2007
Time:
20:00
Server:
85.236.101.9:16867
PsB Streaming:
light_l.gif
Server has not streamed
Password:
n/a Rules: ED league rules
===========================================================

To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=298&day=2007-11-25

All the best,

TheHavenNet[/noparse]

I think all that needs to happen is to have any forum bbCode stripped out and then optionally replaced with equivalent HTML... If I copy that directly into the forum and preview it (without the noparse tags I have used) then it shows up perfectly fine as it does in the original event post.
 

Ronin Storm

Administrator
Staff member
I've made some changes to the script, which I'm going to upload now. This may mean I totally screw over the RSVP emails, or may mean you all get broken ones. Hopefully it'll just magically work. Unfortunately, I can't test this without running the script and it'll process for everyone...
 

thatbloke

Junior Administrator
I've made some changes to the script, which I'm going to upload now. This may mean I totally screw over the RSVP emails, or may mean you all get broken ones. Hopefully it'll just magically work. Unfortunately, I can't test this without running the script and it'll process for everyone...

well i'm sure you'll find out when I start moaning again ;)
 

Ronin Storm

Administrator
Staff member
Bah, testing this one is apparently really difficult because the logic for when to send an email is very tricky. I'll set up a test event for tomorrow and I should know whether it's going to work tonight.
 

Ronin Storm

Administrator
Staff member
Looks like it works, though only after I've beaten the system with a stick to make it send some sample emails.

Dear Ronin Storm,

This is a reminder that an event you RSVP'd for is scheduled to begin soon. If you are no longer able to attend, please update your RSVP status. Otherwise, we look forward to seeing you there!

Event: Test Event, do not use
Scheduled Start Date: 27 Nov 07 (1 Day)
===========================================================
Test event for checking whether RSVP emails are now correctly stripping bbCode.

To that event, here's some bbCode:

* See, a bulleted list
* With two list items
* And a third!


And an image:

Image: http://games.thehavennet.org.uk/THN_rage/misc/thn-minilogo.gif

And some other *bold* and italics and _underlining_.

Even a little colour.
===========================================================

To update your RSVP status or to view this event, visit: http://games.thehavennet.org.uk/calendar.php?do=getinfo&e=320&day=2007-11-27

All the best,

TheHavenNet
 

Traxata

Junior Administrator
Mine appears exactly, like this
email%20capture.jpg


**EDIT **


However, I do beleive thats because of the formatting on the page I C & P'd

the other mail I got was like this

email%20capture2.jpg
 
Top